⬆️ (Cargo.toml): bump version from 0.1.2 to 0.1.3

✨ (connection_details.rs): add user and password parameters to ConnectionDetails::new

♻️ (ls_client.rs): refactor user and password handling into ConnectionDetails

🐛 (ls_client.rs): downgrade TLCP protocol version from 2.5.0 to 2.4.0

✨ (main.rs): update LightstreamerClient::new call to include optional username and password parameters

4 files changed, 24 insertions, 15 deletions

diff --git a/Cargo.toml b/Cargo.toml
index 0dd1e86..e77787e 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "lightstreamer-client"
-version = "0.1.2"
+version = "0.1.3"
 edition = "2021"
 authors = ["Daniel López Azaña <daniloaz@gmail.com>"]
 description = "A Rust client for Lightstreamer, designed to facilitate real-time communication with Lightstreamer servers."
diff --git a/src/connection_details.rs b/src/connection_details.rs
index 916c396..617dd63 100644
--- a/src/connection_details.rs
+++ b/src/connection_details.rs
@@ -171,10 +171,17 @@ impl ConnectionDetails {
     }
 
     /// Creates a new ConnectionDetails object with default values.
-    pub fn new(server_address: Option<&str>, adapter_set: Option<&str>) -> Result<ConnectionDetails, Box<dyn Error>> {
+    pub fn new(
+        server_address: Option<&str>,
+        adapter_set: Option<&str>,
+        user: Option<&str>,
+        password: Option<&str>,
+    ) -> Result<ConnectionDetails, Box<dyn Error>> {
         let mut connection_details = ConnectionDetails::default();
         connection_details.set_server_address(server_address.map(|s| s.to_string()))?;
         connection_details.set_adapter_set(adapter_set.map(|s| s.to_string()));
+        connection_details.set_user(user.map(|s| s.to_string()));
+        connection_details.set_password(password.map(|s| s.to_string()));
 
         Ok(connection_details)
     }
diff --git a/src/ls_client.rs b/src/ls_client.rs
index 12fcd8b..5d37151 100644
--- a/src/ls_client.rs
+++ b/src/ls_client.rs
@@ -212,15 +212,6 @@ impl LightstreamerClient {
 
         /*
 
-        if let Some(user) = &self.connection_details.get_user() {
-            params.insert("LS_user", user);
-        }
-
-        if let Some(password) = &self.connection_details.get_password() {
-            params.insert("LS_password", password);
-        }
-
-
         if let Some(requested_max_bandwidth) = self.connection_options.get_requested_max_bandwidth() {
             params.insert("LS_requested_max_bandwidth", &requested_max_bandwidth.to_string());
         }
@@ -322,7 +313,7 @@ impl LightstreamerClient {
             )
             .header(
                 HeaderName::from_static("sec-websocket-protocol"),
-                HeaderValue::from_static("TLCP-2.5.0.lightstreamer.com"),
+                HeaderValue::from_static("TLCP-2.4.0.lightstreamer.com"),
             )
             .header(
                 HeaderName::from_static("sec-websocket-version"),
@@ -516,12 +507,18 @@ impl LightstreamerClient {
                                         };
                                         let ls_send_sync = self.connection_options.get_send_sync().to_string();
                                         println!("self.connection_options.get_send_sync(): {:?}", self.connection_options.get_send_sync());
-                                        let params: Vec<(&str, &str)> = vec![
+                                        let mut params: Vec<(&str, &str)> = vec![
                                             ("LS_adapter_set", &ls_adapter_set),
                                             ("LS_cid", "mgQkwtwdysogQz2BJ4Ji%20kOj2Bg"),
                                             ("LS_send_sync", &ls_send_sync),
-                                            ("LS_protocol", "TLCP-2.5.0"),
+                                            ("LS_protocol", "TLCP-2.4.0"),
                                         ];
+                                        if let Some(user) = &self.connection_details.get_user() {
+                                            params.push(("LS_user", user));
+                                        }
+                                        if let Some(password) = &self.connection_details.get_password() {
+                                            params.push(("LS_password", password));
+                                        }
                                         let encoded_params = serde_urlencoded::to_string(&params)?;
                                         write_stream
                                             .send(Message::Text(format!("create_session\r\n{}\n", encoded_params)))
@@ -704,8 +701,11 @@ impl LightstreamerClient {
     pub fn new(
         server_address: Option<&str>,
         adapter_set: Option<&str>,
+        username: Option<&str>,
+        password: Option<&str>,
     ) -> Result<LightstreamerClient, Box<dyn Error>> {
-        let connection_details = ConnectionDetails::new(server_address, adapter_set)?;
+        let connection_details =
+            ConnectionDetails::new(server_address, adapter_set, username, password)?;
         let connection_options = ConnectionOptions::default();
 
         Ok(LightstreamerClient {
diff --git a/src/main.rs b/src/main.rs
index 67276a8..901dd22 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -82,6 +82,8 @@ async fn main() -> Result<(), Box<dyn Error>> {
     let client = Arc::new(Mutex::new(LightstreamerClient::new(
         Some("http://push.lightstreamer.com/lightstreamer"),
         Some("DEMO"),
+        None,
+        None,
     )?));
 
     //